v1 addon build watching gets stuck in a loop

[bendemboski]

REPRO:

$ npx ember-cli@5.5 addon my-addon
$ cd my-addon
$ ember try:one embroider-optimized --- ember test -s

EXPECTED:
The build runs once, and only rebuilds when something in the addon is modified

ACTUAL:
The tests run, but there are continuous rebuilds in the background as the build watcher notices various changes in node_modules/.embroider

I reproduced this on MacOS with watchman installed, but I believe it will reproduce on any OS.

[mansona]

Does it also happen if you ran ember serve and went to localhost:4200/tests/ ?

[bendemboski]

@mansona no it doesn't

[mansona]

Well that is fishy 🤔 Is there any specific reason why you would want to use the ember test -s version over ember serve? I'm not saying that we shouldn't fix it or anything, I'm just trying to find out use cases here so I can understand the depth of the problem

[bendemboski]

Oh, a number of reasons:

• It's how I've always done it, and how the pnpm test:ember scripts are set up in the blueprint (pnpm test:ember -s)
• I often do ember test -s --filter 'some module or something'
• It's closer to how things run in CI (I suppose I could do ember serve -e testing or something, but that's more stuff to type)
• I'm building an Electron app, and when using ember-electron you have to use the ember electron:test command (which wraps the built-in test command and suffers from the same issue) -- there's no equivalent of running ember serve and visiting the test URL