Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@embroider/router _getQPMeta looks up "unseen" engine routes #1741

Open
raycohen opened this issue Dec 22, 2023 · 0 comments
Open

@embroider/router _getQPMeta looks up "unseen" engine routes #1741

raycohen opened this issue Dec 22, 2023 · 0 comments

Comments

@raycohen
Copy link
Contributor

Without embroider, it is possible for a route within an engine to still short circuit out of _getQPMeta if the engine was loaded if the route has not been "seen".

With embroider, it doesn't matter if the route has been "seen", we only check if the engine bundle has been loaded.

In my app, this results in controllers getting looked up much earlier than they were before, which causes issues in tests because the instance initializes before test setup has been performed.

Would it be possible to match behavior here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant