Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation issues on macOS 12.5 and Apple clang version 13.1.6 #395

Closed
wants to merge 1 commit into from
Closed

Fix compilation issues on macOS 12.5 and Apple clang version 13.1.6 #395

wants to merge 1 commit into from

Conversation

Vertexwahn
Copy link
Contributor

@Vertexwahn Vertexwahn commented Aug 18, 2022 •
edited

alloc.destroy lead to compilation issues. This PR fix those compilation issues.

I get for instance the following error (on macOS M1 with Apple clang version 13.1.6 (clang-1316.0.21.2.5)) if the fix is not applied:

external/embree/kernels/common/../../common/sys/vector.h:137:17: error: no member named 'destroy' in 'std::allocator<embree::BufferView<char>>'
          alloc.destroy(&items[i]);
          ~~~~~ ^
external/embree/kernels/common/../../common/sys/vector.h:30:9: note: in instantiation of member function 'embree::vector_t<embree::BufferView<char>, std::allocator<embree::BufferView<char>>>::clear' requested here
        clear();
        ^
external/embree/kernels/common/scene_points.h:13:10: note: in instantiation of member function 'embree::vector_t<embree::BufferView<char>, std::allocator<embree::BufferView<char>>>::~vector_t' requested here
  struct Points : public Geometry
         ^
In file included from external/embree/kernels/common/scene_points.cpp:4:
In file included from external/embree/kernels/common/scene_points.h:6:
In file included from external/embree/kernels/common/../subdiv/../common/buffer.h:6:
In file included from external/embree/kernels/common/../subdiv/../common/default.h:8:
In file included from external/embree/kernels/common/../../common/tasking/../sys/thread.h:9:

Fixes #385

@svenwoop
Copy link
Contributor

Merged into our internal devel branch. This will be in the next release.

@svenwoop svenwoop closed this Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fails to build in C++20 mode
2 participants
@Vertexwahn @svenwoop