[Tests] Improve test suite coverage for Routing

[jenweber]

The goal of this issue is to write some new tests or modify existing tests to improve coverage. There have been a series of routing bugs that may be related, and improved test coverage may have been able to prevent them. Multiple people can help work on this issue - just comment with what you are working on, and be sure to read through other people's comments.

To do:

• read through some of the issues below
• Write a test to help cover one of the problem areas

Past bug reports/issues:

• [Bug] <RouterService>#transitionTo incorrectly re-runs the the model hook when query params do not change #19497
• Redirecting a transition to same route with different query params does not work unless transition is aborted before #18577
• Router Service transitionTo breaks with Query Params on nested transition #17494
• Cannot read property 'name' of undefined when trying to set queryParams in beforeModel #17118
• RouterService forces model to refresh when queryParams unchanged #16349
• transitionTo queryParams on initial render still broken #14875
• Aborting a transition clears the resolved model #14721
• Query Params Reset to Default Values on Initial Render If transitionTo is called in beforeModel #12169
• QP only transition in beforeModel of application route throws error #11563

[laulujan]

Hello, I would like to give it a try on one of the tests needed, I'll check on the reports and comment later on the one I'll be working on!!!

[jenweber]

Thanks @laulujan! Let us know if you have any questions. I haven’t worked in this area of the codebase myself, but I can find people who have!

[iigorcunha]

Hello @jenweber, I saw the test but how can I find the coverage? is there any place to see a coverage report? I would like to work on it.

[Aditya-eddy]

@jenweber can you please tell what is meant by write a test. I am a newbie

[jenweber]

Hi @Aditya-eddy, welcome and thanks for your willingness to help out! I think the best way to learn about writing tests is to do the official Ember tutorial: https://guides.emberjs.com/release/tutorial/part-1/ Throughout the sections, you will write many different kinds of tests, and then Github Issues like this one will make more sense.

[jenweber]

Also for anyone else looking into helping with this ticket - unfortunately I don't have much additional context or guidance to share to share. Part of the task at hand is to figure out what the tests are like for this area of the codebase and what can be improved. I haven't worked on routing at all myself. I just know that this is a problem area based on user reports and some comments from other core team members. Good luck!

[jenweber]

Hi @arjot-rai thanks for your interest in helping! It would be great if you give this a try. You should assume that no one is working on this, since the last comments are from many months ago.

We don’t typically assign people to issues, so that no one is blocked by waiting for a maintainer to do something. The way we manage who is working on an issue is that volunteers comment, just as you did. If it’s been a month since someone commented to say that they can help, and there’s not a PR, then you can ask if anyone else is working on it. If no one replies, assume no one is working on it. It’s a bit different than a workplace, since there are many volunteers who come and go.

[igmtz]

Hi @jenweber is this issue still relevant? I would like to contribute 😁