QUnit Blueprints Quest Issue #15933

alexander-alvarez · 2017-12-06T19:17:55Z

Background
We need to implement changes in blueprints and docs realted to RFC 232 and RFC 268.
(Some background for those unfamiliar http://rwjblue.com/2017/10/23/ember-qunit-simplication/)

As of ember-cli-qunit@^4.1.1 (which is in the default blueprint as of ember-cli@2.17), we can implement the "Simplified QUnit" style tests in all tests except for acceptance tests.
In a future release of ember-qunit (likely 3.2.x), we will be able to leverage the implementation of setupApplicationTest from RFC 268 for use in acceptance-tests. Once these changes are implemented upstream, we must implement the blueprint updates.
Currently, we have no way to generate these test files but we can run the ember-qunit-codemod to migrate test files and continue to iterate on the final output in the blueprint specific pull requests.

The desired behavior when generating testing blueprints is to, generate "Simplified QUnit" style tests if supported by the host app. We have several tasks below to extend the blueprints to support the "Simplified QUnit" style blueprints alongside the legacy, and ember-mocha blueprints. We can likely add to the behavior of test-framework-detector.js to support this other extension. Once these changes are completed we also need to update the guides to be consistent with the current ember-cli codebase. We should work with @rwjblue and the learning team (cc @locks) to determine how we best teach this.

Tasks

To pick up one of these items, please comment below and we'll update the checklist with :lock: @your-name-here...

The text was updated successfully, but these errors were encountered:

rwjblue · 2017-12-06T19:18:34Z

Awesome, thanks for organizing this @alexander-alvarez!

Turbo87 · 2017-12-06T19:26:27Z

@alexander-alvarez should we use qunit for the new API blueprints and something else instead of qunit for the old blueprints? this would seem more intuitive to me 🤔

Turbo87 · 2017-12-06T19:27:36Z

also I'm wondering if we should do the implementation in https://github.com/alexander-alvarez/ember-qunit-nested-module-blueprints-polyfill first and once those are solid we can import them here

rwjblue · 2017-12-06T19:34:12Z

@Turbo87 - I'd prefer to land the "real" implementations first (so that the polyfill truly is a polyfill). If that turns out to be costly (or I'm too much of a blocker in landing PR's) we can swap to targeting the polyfill addon first...

rwjblue · 2017-12-06T21:29:41Z

OK, first implementation is done and landed (along with the test framework detector changes required to support the path forward). The game is afoot!

snewcomer · 2017-12-07T03:29:13Z

Doing the helper-test right now.

RobbieTheWagner · 2017-12-07T16:59:18Z

@rwjblue I'm always happy to work on blueprints. Want to assign a couple my way?

Turbo87 · 2017-12-07T17:00:26Z

@rwwagner90 choose one and announce it here, so that others are not doing the same work too :)

RobbieTheWagner · 2017-12-07T17:08:27Z

@Turbo87 I'm not picky, but I'll randomly choose route-test

rwjblue · 2017-12-07T19:58:58Z

Updated description:

🔒 route-test for @rwwagner90
✅ helper-test
✅ component-test

snewcomer · 2017-12-07T20:55:04Z

Tackling controller && initializer && instance-initializer tests in 3 separate PR's!

christophermlne · 2017-12-07T23:05:42Z

If there's anything left I could take one.

alexander-alvarez · 2017-12-07T23:10:23Z

@christophermlne mixin, service, and ~~util~~ are still up for grabs

snewcomer · 2017-12-08T02:01:10Z

Taking the utils. @christophermlne lmk if you want to tackle that one or want to take on either service or mixin!

boyanyordanov · 2017-12-08T08:23:34Z

I will try to do mixin and if I manage I will look into service as well.
I haven't contributed to ember yet so I don't know if I'll be in over my head.

Turbo87 · 2017-12-08T08:59:14Z

I haven't contributed to ember yet so I don't know if I'll be in over my head.

@boyanyordanov don't worry, we're here to help you if you have questions :)

boyanyordanov · 2017-12-08T11:46:29Z

I'll go ahead and add a PR for service-test too.

This updates the testing section about helpers according to the new Ember Qunit testing patterns proposed in RFC#232.

This updates the controller testing section according to the new Ember Qunit testing patterns proposed in RFC#232.

This updates the route testing section according to the new Ember QUnit testing patterns proposed in RFC#232.

This updates the model testing section according to the new Ember Qunit testing patterns proposed in RFC#232.

This updates the introduction into testing introducing new concepts of the Ember Qunit testing API proposed in RFC#232 and RFC#268.

This updates the title of the former "Unit Testing Basics" section to "Testing Basics" to avoid talking about "container" tests in an originally "unit" test focused section.

This updates the integration testing section according to the new Ember Qunit testing patterns proposed in RFC#232.