Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route model hook is not run on transition in Ember 2.15 #15661

Closed
mani-mishra opened this issue Sep 12, 2017 · 3 comments
Closed

Route model hook is not run on transition in Ember 2.15 #15661

mani-mishra opened this issue Sep 12, 2017 · 3 comments

Comments

@mani-mishra
Copy link
Contributor

In ember 2.15, route's model doesn't run when transitioning from a parent route.
For example:
If the app is currentnly, at /student and displays student list, selecting a student, transitions to student/<id>. The model hook in route for student/<id> is not run.
All other hooks run, in order of beforeModel => afterModel => setupController

This doesn't happen, when I directly load the route via hard refresh of student/<id>.

Previous to ember 2.15, hooks run in beforeModel => model => afterModel => setupController in all cases.

@rwjblue
Copy link
Member

rwjblue commented Sep 12, 2017

We have a number of tests in this area that are not showing a regression so I suspect that what you are experiencing is situational or dependent on some other factors. Can you create a reproduction that shows the problem you are describing?

@mani-mishra
Copy link
Contributor Author

@rwjblue On more detailed debugging, the issue that we are seeing is a result of #15621. We are trying to pass the id param of the route, from a partial, which comes as undefined.

I'll close this issue.

@rwjblue
Copy link
Member

rwjblue commented Sep 13, 2017

Thanks for following up, we're trying to prioritize #15621 so we can get a fix out soonish. Sorry for the delays there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants