Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit the 'until' field on backtracking rerender deprecation for 2.8 LTS and 2.9 #14663

Closed
Gaurav0 opened this issue Dec 1, 2016 · 2 comments
Closed

Edit the 'until' field on backtracking rerender deprecation for 2.8 LTS and 2.9 #14663

Gaurav0 opened this issue Dec 1, 2016 · 2 comments
Labels
Needs Team Discussion

Comments

@Gaurav0
Copy link
Contributor

Gaurav0 commented Dec 1, 2016

Given #13948 if we are going to keep the assertion in Glimmer 2, should we release patches for 2.8 LTS and 2.9 to indicate that the deprecation will go away and behavior will stop working in 2.10 ?
@ghost
Copy link

ghost commented Dec 6, 2016

I think this would be helpful. I was confused by seeing our app's test suite break on 2.10 despite the deprecation warnings indicating until 3.0.

@rwjblue
Copy link
Member

rwjblue commented Dec 7, 2018

Agree that this whole situation was unfortunate and very annoying. I'm happy to accept PR's against those older branches if folks have time and care strongly.

@rwjblue rwjblue closed this as completed Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs Team Discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rwjblue @locks @Gaurav0