Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember 2.10.0 didUpdateAttrs firing incorrectly #14654

Closed
amk221 opened this issue Nov 29, 2016 · 3 comments
Closed

Ember 2.10.0 didUpdateAttrs firing incorrectly #14654

amk221 opened this issue Nov 29, 2016 · 3 comments

Comments

@amk221
Copy link
Contributor

amk221 commented Nov 29, 2016

Here is a Twiddle:
https://ember-twiddle.com/fd53b517896332db9f362195aefe588f?openFiles=components.my-component.js%2Ctemplates.components.my-component-option.hbs

  • Run the twiddle with 2.9.0
  • Click on some options and notice nothing is logged to the console.
  • Switch to 2.10.0 and notice that didUpdateAttrs is being called unnecessarily.

This manifests itself as a failing test in my ember-select-box repo.

@amk221 amk221 changed the title didUpdateAttrs firing incorrectly Ember 2.10.0 didUpdateAttrs firing incorrectly Dec 1, 2016
@chancancode
Copy link
Member

Thanks for reporting! I'm looking into fixing this one

@amk221
Copy link
Contributor Author

amk221 commented Dec 7, 2016

Thank you!

@chancancode
Copy link
Member

@amk221 this was fixed in 2.10.1 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants