Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message "Assertion Failed: A helper named 'something-something' could not be found" #14532

Closed
adam-knights opened this issue Oct 27, 2016 · 4 comments · Fixed by #14587

Comments

@adam-knights
Copy link

Lets say you add

{{something-something a=b}}

to any Ember template.

The error you receive is Assertion Failed: A helper named "something-something" could not be found.

Why 'a helper'? The user could be trying to reference a component. For me the most common case is a user typo when referencing the component.

A couple of our new guys stumbled on this error, could/should it be improved to:

Assertion Failed: A component or helper named "something-something" could not be found

?

@rwjblue
Copy link
Member

rwjblue commented Oct 27, 2016

Sounds good to me, would you mind submitting a PR that we can review?

@adam-knights
Copy link
Author

Will do :)

@serenaf
Copy link
Contributor

serenaf commented Nov 8, 2016

@adam-knights Hey Adam, i created a PR for this, see here #14587

@adam-knights
Copy link
Author

Thanks @serenaf , i hadnt found the time yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants