-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output window comes into foreground whenever anything bad happens #2
Comments
I'm pretty sure this is on VS Code, as the same happens when not in an Ember project. |
As far as I know the behaviour when the output channel reveals itself can be defined by the extension in the client options, so this can (and probably should) be fixed on our side. |
It looks like this was occurring for Angular's extension also. See microsoft/vscode#31474 (comment) and |
Would be nice to have this fixed soon. Really annoying issue. |
As far as I can tell we have to specify A PR would be welcomed :) |
As per this part of the file, I would assume the desired behaviour is 4 (Never)? Seems like somebody just needs to add revealOutputChannelOn: RevealOutputChannelOn.never to that file you linked. I personally have no experience in building vscode extensions but could be an easy fix for somebody. |
Great to see this fixed :) Can't wait for another release |
Just came here to report this issue and am also looking forward to a new release. (Thanks for the awesome work here, @t-sauer.) |
Any errors that are coming through the Ember Language Server cause the Output window to switch to
Ember Language Server
and come into the foreground. This is a bit overzealous as even writing out the name of a component causes an error for each letter typed until the name is correct.I tried to record a gif but LICEcap recorded black for some reason
For example:
{{!--templates/application.hbs--}} Hello World
All is well, no errors are present. Begin adding a component into my template:
An error is logged for each input letter:
Until the component name is valid:
Each error causing the Output window to appear, which is very annoying.
The text was updated successfully, but these errors were encountered: