Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: autofix of attribute-order removes empty string attribute/argument values #3054

Open
IgnaceMaes opened this issue Apr 10, 2024 · 1 comment

Comments

@IgnaceMaes
Copy link

Description

The auto fix of attribute-order removes empty string values for attributes and arguments.

Example

Before:

<SomeComponent @b="" @a="foo" />

After:

<SomeComponent @a="foo" @b />

Expected:

<SomeComponent @a="foo" @b="" />

Versions

Seeing this behaviour both on ember-template-lint@5.11.2 and latest (ember-template-lint@6.0.0)

@IgnaceMaes
Copy link
Author

IgnaceMaes commented Apr 10, 2024

Seems like this was reported before: #2692

And mentioned as fixed in #2701

Why am I still seeing this issue then? 🤔

EDIT: The issue that was fixed was for the combination of a single attribute and argument. That does work now. Having more than one argument/attribute with one having an empty value seems an actual remaining bug then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant