Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require-input-label false positive #3006

Open
amk221 opened this issue Dec 18, 2023 · 3 comments
Open

require-input-label false positive #3006

amk221 opened this issue Dec 18, 2023 · 3 comments
Labels

Comments

@amk221
Copy link
Contributor

amk221 commented Dec 18, 2023

const input = 'foo';

await render(<template>
  <MyComponent @string={{input}} />
</template>);

...it's picking up {{input}}

amk221 added a commit to zestia/ember-rich-intl that referenced this issue Dec 18, 2023
@bmish bmish added the bug label Dec 18, 2023
@bmish
Copy link
Member

bmish commented Dec 18, 2023

CC: @MelSumner who implemented the rule.

@MelSumner
Copy link
Contributor

I can understand why it's picking it up, but I don't know how to edit the rule without making it less effective. Can you rename {{input}} to be something more precise for your use case?

@amk221
Copy link
Contributor Author

amk221 commented Feb 8, 2024

Fair point :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants