Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y improvements #86

Open
jenweber opened this issue Dec 10, 2017 · 5 comments
Open

a11y improvements #86

jenweber opened this issue Dec 10, 2017 · 5 comments

Comments

@jenweber
Copy link
Contributor

An effort to rehabilitate #26

@jenweber
Copy link
Contributor Author

jenweber commented Dec 26, 2017

Any changes made to styling in this issue/PR also need to go in ember-learn/ember-cli-tutorial-style#2

I'll keep the alt tag improvements, label for, and the styling. I'll write a quick blurb about alt, use the Tomster/Zoey says to suggest ember-a11y while explaining labels, and just silently update the styling. I'll include only ember-a11y-testing in the super-rentals app, but only for tests. (I'll skip focusing-outlet)

@luxzeitlos
Copy link

I'm not sure if this is related, but the red/green contrast here is very suboptimal. Its not a real problem - I can just mark the code snipped, but a improvement would be nice for newcomers with color blindness I think.

@toddjordan
Copy link
Contributor

ok, this is happening @jenweber! 🔥 The PR is ready. just needs some changes I made to get it building with the current level of code, and for one of us to update the tutorial guides source

@toddjordan
Copy link
Contributor

@luxferresum I think what you mention is more an issue with the guides than this tutorial example. I encourage you to write an issue to https://github.com/ember-learn/guides-source

@toddjordan
Copy link
Contributor

I created an issue for adding the a11y updates here to guides: ember-learn/guides-source#778

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants