Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accessibility issue of no lang attribute #148

Closed
wants to merge 1 commit into from

Conversation

rajasegar
Copy link

@rajasegar rajasegar commented Apr 1, 2020

Fixes #147
Using Chrome Dev Tools Accessibility audit

Before:

Screenshot 2020-04-01 at 11 05 59 AM

After:

Screenshot 2020-04-01 at 11 06 30 AM

@netlify
Copy link

netlify bot commented Apr 1, 2020

Deploy request for ember-super-rentals pending review.

Review with commit 127eff9

https://app.netlify.com/sites/ember-super-rentals/deploys

@chancancode
Copy link
Contributor

Hi @rajasegar, thank you! Sorry I didn't pay enough attention when replying from my phone. We should totally do these changes, but these files are generated from the executable markdown in https://github.com/ember-learn/super-rentals-tutorial/, so we should make the changes there along with the accompanying explanatory text. For this change, I think it somewhere towards the end of the first chapter (source | rendered) would be a good place for this. What do you think?

@rajasegar
Copy link
Author

Sure @chancancode sounds good. I will create a PR there also.

@locks locks self-assigned this Apr 9, 2020
@MelSumner
Copy link
Member

@rajasegar were you able to create the PR in the correct place? I'm going to go ahead and close this issue on this repo. 👍

@MelSumner MelSumner closed this Apr 16, 2020
@rajasegar
Copy link
Author

@MelSumner Yes, I think I got it where, will create a PR there asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a11y quick wins : lang attribute in index.html
4 participants