Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "The Ember Times" from the title of each blog. #904

Open
mansona opened this issue Feb 4, 2021 · 3 comments
Open

Remove "The Ember Times" from the title of each blog. #904

mansona opened this issue Feb 4, 2021 · 3 comments
Labels
pinned Don't mark me as stale!

Comments

@mansona
Copy link
Member

mansona commented Feb 4, 2021

If you visit a single post of the ember times you should see the Ember Times logo and then just the title of the blog Issue No. 166

Example: https://blog.emberjs.com/the-ember-times-issue-166

This should still have the-ember-times-issue-166 in the url and the meta title should also have "The Ember Times" in it 👍

@mansona mansona created this issue from a note in Emberify and Redesign the Ember Blog (Todo (optional)) Feb 4, 2021
@mansona mansona removed this from Todo (optional) in Emberify and Redesign the Ember Blog Feb 4, 2021
@ijlee2
Copy link
Member

ijlee2 commented Feb 5, 2021

I don't think this is a good idea. The logo image has alt="" and role="presentation" to indicate that it's decorative. We'd also need to update every post on dev.to.

@mansona
Copy link
Member Author

mansona commented Feb 5, 2021

This was something that came out of a last-minute review of the Blog before the new design went live. I think it was @pichfl 's idea so maybe he can explain more the rationale why we should consider it. If I remember correctly it was something to do with too much repetition 🤔

I'm not married to this idea so if we agree so if we discuss it and agree that it's not ok or we don't want to do it then that's ok too 👍

@stale
Copy link

stale bot commented Jun 7, 2021

This issue has been automatically marked stale. If this issue is something that still needs work, please add a comment and it will remain open, otherwise it will close in 7 days. You are welcome to open a new issue if you miss the window. Thanks!

@stale stale bot added the stale label Jun 7, 2021
@amyrlam amyrlam added pinned Don't mark me as stale! and removed stale labels Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinned Don't mark me as stale!
Projects
None yet
Development

No branches or pull requests

3 participants