Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature: Control how much of the blog appears on https://blog.emberjs.com/ post preview #886

Open
amyrlam opened this issue Jan 16, 2021 · 3 comments
Labels
help wanted We need your help! pinned Don't mark me as stale!

Comments

@amyrlam
Copy link
Member

amyrlam commented Jan 16, 2021

Current Behavior

On blog.emberjs.com, blog "preview" appears like so:
image

Expected Behavior

On blog.emberjs.com, blog "previews" should honor the line break, as it does on the individual post page:
image

Possible Solution

Add feature to blog code / empress. Previously, this was done with <!-- READMORE --> in the code

@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked stale. If this issue is something that still needs work, please add a comment and it will remain open, otherwise it will close in 7 days. You are welcome to open a new issue if you miss the window. Thanks!

@stale stale bot added the stale label Jun 2, 2021
@amyrlam amyrlam added pinned Don't mark me as stale! and removed stale labels Jun 2, 2021
@mixonic
Copy link
Contributor

mixonic commented Jul 4, 2021

This was originally (in the old blog) dealt with via the introduction of <!-- READMORE --> as a break for where to cut off content on the blog index. If that behavior can be resurrected a lot of post cutoffs that already exist will be applied and look much better.

@amyrlam amyrlam added the help wanted We need your help! label Oct 6, 2021
@amyrlam amyrlam changed the title Blog preview doesn't honor line break New feature: Have Blog preview page honor a line break Oct 6, 2021
@amyrlam amyrlam changed the title New feature: Have Blog preview page honor a line break New feature: Control how much of the blog appears on https://blog.emberjs.com/ post preview Oct 6, 2021
@amyrlam
Copy link
Member Author

amyrlam commented Oct 6, 2021

Updated this issue for Hacktoberfest. I think that it would make sense to move the issue to https://github.com/ember-learn/empress-blog-ember-template/issues, but needs investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted We need your help! pinned Don't mark me as stale!
Projects
None yet
Development

No branches or pull requests

2 participants