API docs styling tweaks #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasnys
force-pushed
the
wide-mode
branch
2 times, most recently
from
ec3d802
to
885c694
Compare
added 4 commits
September 2, 2023 14:22
|
One thing I'm concerned with in this PR is the |
MinThaMie
reviewed
Sep 7, 2023
There was a problem hiding this comment.
Am I correct when I understand that you made it min-content because the sidebar-items were not wrapping? Because I think we would love it if the sidebar-width is consistent between all the "apps"/websites and using min-content does not guarantee that. So if that's what you are aiming for, I suggest using word-wrap.
MinThaMie
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #879 as well as some other styling tweaks:
sidebar-container--full-width(Start using "wide mode" in the redesign branch #879) and add necessary paddingLet me know if one of the additional styling tweaks (font-size changes, header width changes, sidebar width changes) are undesired as I didn't talk this through with anyone.
Screenshots before and after