Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trailingZeroDisplay not working #1775

Closed
2 tasks done
amk221 opened this issue Jul 28, 2023 · 4 comments
Closed
2 tasks done

trailingZeroDisplay not working #1775

amk221 opened this issue Jul 28, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@amk221
Copy link

amk221 commented Jul 28, 2023

  • I am on the latest ember-intl version
  • I have searched the issues of this repo and believe that this is not a duplicate

Environment

  • Ember Version: 4.12
  • Ember CLI Version: 4.12
  • Ember Intl Version: 6.0.0-beta.6
  • Browser(s): chrome
  • Node Version: 18.16

Steps to Reproduce

Minimal reproduction: https://github.com/amk221/-ember-intl-currency-formatting/blob/5759acf583ce189a30f3daaea67596c20d4834e0/app/routes/application.js#L23-L29

@ijlee2
Copy link
Contributor

ijlee2 commented Aug 28, 2023

@amk221 Sorry for a late reply. I haven't had studied the codebase for ember-intl yet, so I don't readily know why passing currencyOptions.trailingZeroDisplay (as seen in your code example) didn't "just work." Did you happen to get to spend some time debugging the issue?

@ijlee2 ijlee2 added the bug Something isn't working label Aug 28, 2023
@amk221
Copy link
Author

amk221 commented Aug 29, 2023

Hi,

I think it's because ember-intl uses formatjs under the hood, and that the bug probably lies there

@BennCon
Copy link

BennCon commented May 16, 2024

Resolved with the formatjs version bump in 6.4.1: Updated dependencies 🙂

@ijlee2
Copy link
Contributor

ijlee2 commented May 17, 2024

@BennCon Thanks for a follow-up. I'll close this issue then.

@ijlee2 ijlee2 closed this as completed May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants