Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.1.x does not work with latest stable ember-mocha release #238

Open
kevinansfield opened this issue Apr 1, 2019 · 9 comments
Open

2.1.x does not work with latest stable ember-mocha release #238

kevinansfield opened this issue Apr 1, 2019 · 9 comments

Comments

@kevinansfield
Copy link

I've added the start() call from ember-exam to our test-helper.js file (even though the current ember-mocha release doesn't use an explicit start() call) which allows our tests to run but I still get this error when attempting to run our test suite and parallelization doesn't occur:

Global error: Uncaught Error: Unable to find a suitable test loader. You should ensure that one of `ember-qunit` or `ember-mocha` are added as dependencies.

Looking at the getTestLoader() code here it's checking for the existence of ember-mocha/test-loader but ember-mocha does not have such an export or file.

ember-exam@2.1.1
ember-mocha@0.14.0

kevinansfield added a commit to kevinansfield/Ghost-Admin that referenced this issue Apr 1, 2019
no issue
- ignore `ember-exam` until it's compatible with latest stable of `ember-mocha`
  - see ember-cli/ember-exam#238
- moved `ember-exam`, `ember-mocha`, and `testem` into their own group so changes to test env don't cause addon upgrade PRs to fail
kevinansfield added a commit to kevinansfield/Ghost-Admin that referenced this issue Apr 1, 2019
no issue
- ignore `ember-exam` until it's compatible with latest stable of `ember-mocha`
  - see ember-cli/ember-exam#238
- moved `ember-exam`, `ember-mocha`, and `testem` into their own group so changes to test env don't cause addon upgrade PRs to fail
@step2yeung
Copy link
Collaborator

step2yeung commented Apr 1, 2019

@kevinansfield Thanks for filing this issue!
It looks like you were getting this error with TryGhost/Ghost-Admin ?
Could you share the exact steps to produce this error?

@step2yeung
Copy link
Collaborator

I was able to reproduce this. The problem is due to test-loader is available on master, but not in the releases yet. Will be addressing this

kevinansfield added a commit to TryGhost/Admin that referenced this issue Apr 2, 2019
no issue
- ignore `ember-exam` until it's compatible with latest stable of `ember-mocha`
  - see ember-cli/ember-exam#238
- moved `ember-exam`, `ember-mocha`, and `testem` into their own group so changes to test env don't cause addon upgrade PRs to fail
@amk221
Copy link

amk221 commented Apr 2, 2019

I don't use ember-mocha, but might I be experiencing the same/similar issue?

not ok 1 Chrome 73.0 - [undefined ms] - Global error: Uncaught TypeError: (0 , _load.default) is not a function at http://localhost:7357/assets/tests-dev.js, line 48328
    ---
        Log: |
            { type: 'error',
              testContext: {},
              text:
               'Uncaught TypeError: (0 , _load.default) is not a function at http://localhost:7357/assets/tests-dev.js, line 48328\n' }
    ...

...downgrading to ember-exam 2.0.3 works ok

@step2yeung
Copy link
Collaborator

@amk221 ember-exam 2.1.2 removed the load API and instead introduces the start() API
Please see the Read me for how to set this up.

@amk221
Copy link

amk221 commented Apr 2, 2019

Oh, sorry - I did check the changelog, but it's not mentioned.

@step2yeung
Copy link
Collaborator

@amk221 no worries, what you faced is reasonable since it was a breaking change that was introduced into a minor version bump. #242 will fix this. So you can use load() instead.

@stefanpenner
Copy link
Contributor

#242 Was merged and released.

@maprules1000
Copy link

I'm still seeing this issue with ember-exam@3.0.1 and ember-mocha@0.14.0 after updating the test-helper.js file.

Uncaught Error: Unable to find a suitable test loader. You should ensure that 
one of `ember-qunit` or `ember-mocha` are added as dependencies. at 
http://localhost:7357/assets/test-support.js, line 51528

@step2yeung
Copy link
Collaborator

step2yeung commented Apr 9, 2019

@maprules1000 Apologies! I think this needs to be addressed, since the changes in 3.0.1 was working with the master of ember-mocha rather than the latest release of ember-mocha 0.14.0
Lets reopen this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants