Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove emoji alias #7426

Closed
tristanpemble opened this issue Nov 7, 2017 · 4 comments
Closed

Remove emoji alias #7426

tristanpemble opened this issue Nov 7, 2017 · 4 comments

Comments

@tristanpemble
Copy link
Contributor

tristanpemble commented Nov 7, 2017

Re: #6928

The fact that Yarn's output includes a hamster emoji that I cannot ignore, has unearthed a bug in our deployment tooling. It does not handle unicode output well, and since we cannot block the output of the emoji in our yarn install like is automatically done via yarnpkg/yarn#405 , this has blocked my team.

I am submitting a bug report to the tool we are using to request that it properly handle the Unicode output. That said, and I don't want to be a party pooper, but forcing all tooling to support unicode output over a fun hamster emoji alias seems non-ideal.

@kellyselden
Copy link
Member

kellyselden commented Nov 7, 2017

Seems like a valid enough reason to remove to me.

@rwjblue
Copy link
Member

rwjblue commented Nov 7, 2017

I think we are generally happy to land a PR that does this (we should change the PR to target the beta branch at least, so that 2.17.0 will include the required fixes).

forcing all tooling to support unicode output over a fun Hamster emoji alias seems non-ideal

All CI related tooling should already support unicode output or its probably not worth using. There are more languages in the world than those that can be written in ASCII... 😄

@tristanpemble
Copy link
Contributor Author

tristanpemble commented Nov 7, 2017

All CI related tooling should already support unicode output or its probably not worth using. There are more languages in the world than those that can be written in ASCII... 😄

I agree; this is not a situation I'm happy to be in 😛

@kellyselden
Copy link
Member

fixed in #7427

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants