Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling Custom Versions of Ember #17

Open
blimmer opened this issue May 20, 2016 · 1 comment
Open

Handling Custom Versions of Ember #17

blimmer opened this issue May 20, 2016 · 1 comment

Comments

@blimmer
Copy link

blimmer commented May 20, 2016

I'm stuck on 1.12 on a project and have a custom patched version of Ember that looks like this in my bower.json.

"ember": "Ibotta/ember#f98a92242cf5d0635c07fc6a55d10d22322a2dce",

When ember-cli-version-checker encounters this, I get this exception:

Invalid Version: 1.12.2.f2794747
TypeError: Invalid Version: 1.12.2.f2794747
  at new SemVer (/Users/blimmer/code/webapps/ibotta-web/node_modules/ember
-get-helper/node_modules/ember-cli-version-checker/node_modules/semver/sem
ver.js:295:11)
  at compare (/Users/blimmer/code/webapps/ibotta-web/node_modules/ember-get-helper/node_modules/ember-cli-version-checker/node_modules/semver/semver.js:571:10)
  at Function.lt (/Users/blimmer/code/webapps/ibotta-web/node_modules/ember-get-helper/node_modules/ember-cli-version-checker/node_modules/semver/semver.js:605:10)
  at DependencyVersionChecker.(anonymous function) [as lt] (/Users/blimmer/code/webapps/ibotta-web/node_modules/ember-get-helper/node_modules/ember-cli-version-checker/index.js:68:26)
  at Class.module.exports.treeFor (/Users/blimmer/code/webapps/ibotta-web/node_modules/ember-get-helper/index.js:15:31)
  at EmberApp.<anonymous> (/Users/blimmer/code/webapps/ibotta-web/node_modules/ember-cli/lib/broccoli/ember-app.js:342:20)
  at Array.map (native)
  at EmberApp.addonTreesFor (/Users/blimmer/code/webapps/ibotta-web/node_modules/ember-cli/lib/broccoli/ember-app.js:340:30)
  at EmberApp._processedAppTree (/Users/blimmer/code/webapps/ibotta-web/node_modules/ember-cli/lib/broccoli/ember-app.js:530:25)
  at EmberApp.appAndDependencies (/Users/blimmer/code/webapps/ibotta-web/node_modules/ember-cli/lib/broccoli/ember-app.js:807:24)
  at EmberApp.javascript (/Users/blimmer/code/webapps/ibotta-web/node_modules/ember-cli/lib/broccoli/ember-app.js:882:34)
  at EmberApp.toArray (/Users/blimmer/code/webapps/ibotta-web/node_modules/ember-cli/lib/broccoli/ember-app.js:1250:10)
  at EmberApp.toTree (/Users/blimmer/code/webapps/ibotta-web/node_modules/ember-cli/lib/broccoli/ember-app.js:1272:30)

is there a workaround?

@jamesarosen
Copy link

Possibly a duplicate of #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants