Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--to flag still prompting for user interaction #1148

Open
elwayman02 opened this issue Jun 28, 2021 · 5 comments
Open

--to flag still prompting for user interaction #1148

elwayman02 opened this issue Jun 28, 2021 · 5 comments

Comments

@elwayman02
Copy link
Contributor

elwayman02 commented Jun 28, 2021

When we run a command using the --to flag (e.g. ember-cli-update --to 3.26.1), the output still prompts to ask which version we want:

? Blueprint updates have been found. Which one would you like to update? addon,
current: 3.20.0, latest: 3.27.0

Hitting enter a couple times moves past this prompt and produces the expected behavior (that is, it updates to the target version and not, say, latest), but I would expect that providing the --to option for ember-cli-update would preempt the need to ask the user this question. This becomes particularly important when attempting to use ember-cli-update as a codemod across multiple projects at the same time, or via an automated job. We want to be able to provide all the necessary information when the command is invoked, so that no process gets blocked on waiting for interaction with a user prompt.

@Timbuktu1982
Copy link

Hey. In the meantime, is there already a solution to the problem? THX

@Timbuktu1982
Copy link

Hey. I have create a new fork with a fix for the problem. See https://github.com/Timbuktu1982/ember-cli-update...

@elwayman02
Copy link
Contributor Author

@Timbuktu1982 I'm sure if you open a PR for your fix, people would be happy to help review getting it into the main project!

@Timbuktu1982
Copy link

Have done now...

@pernambucano
Copy link

Hi, now that we have a PR, do we need to do something to help merge it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants