Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: hierarchal blueprint support or dependent blueprint support #1103

Open
gitstevenpham opened this issue Jan 14, 2021 · 3 comments

Comments

@gitstevenpham
Copy link
Contributor

@elwayman02 and I were discussing this and I wanted to capture the essence of our conversation in this feature request.

Jordan has a use case where he wants to write a blueprint for the collection of Ember addon projects his team maintains. The thing is though he needs another addon's blueprint to be generated before running his blueprint so that it can layer changes on top of that. From my understanding of the ember-cli-update codebase, it will only install and generate one blueprint per run.

Some of the conversation items we had were:

  • How will version management work for dependent packages containing the blueprints?
  • How should the dependencies be defined?
  • How will ember-cli-update prompt for updates
@elwayman02
Copy link
Contributor

To give more context - Let's say that we have a custom blueprint that provides additional project boilerplate on top of the base Ember blueprints, including making changes that undo or alter some of the changes in the base blueprint (e.g. different linting config, changing LICENSE.md, etc). This blueprint exists for a team or org to generate new projects specific to their infrastructure and the way they write code, in the same vein as why the base Ember blueprint exists. Whenever a new version of Ember is released, the base blueprint may change in ways that require further changes to be made to this second blueprint, particularly if the new changes conflict with some of the alterations made in the custom blueprint. When upgrading a project to the new version of Ember, we would want to run the base blueprint and the custom blueprint together, applying them as a net set of changes.

As it stands right now, I believe you would have to run the base blueprint, commit those changes, and then run the custom blueprint separately and have it undo some of those committed changes in a second commit. The question is, can we make this more ergonomic for consumers of ember-cli-update who have use-cases like this?

@kellyselden
Copy link
Member

This seems like something that could be added to ember-cli-update.json; a blueprint dependency list for a given blueprint.

@rwjblue
Copy link
Member

rwjblue commented Jan 20, 2021

This seems like something that could be added to ember-cli-update.json; a blueprint dependency list for a given blueprint.

Ya, agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants