Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obsolete font-lock-reference-face in ess-stata-lang.el #11

Open
djh1202 opened this issue Oct 8, 2023 · 7 comments
Open

obsolete font-lock-reference-face in ess-stata-lang.el #11

djh1202 opened this issue Oct 8, 2023 · 7 comments

Comments

@djh1202
Copy link

djh1202 commented Oct 8, 2023

I had trouble rendering font colors in .do files.

Turns out the problem was ess-stata-lang.el, which defines font-lock-reference-face, which has been marked obsolete for awhile. When I replaced font-lock-reference-face with font-lock-constant-face, things started working again.

@rsparapa
Copy link
Contributor

rsparapa commented Oct 9, 2023

Huh? I don't even see a file named ess-stata-lang.el

@BrendanHalpin
Copy link
Contributor

It's there: ess-stata-mode is separate from core ESS, but hasn't changed often. In fact, I feel like the only user, so Hi, djh1201!

@rsparapa
Copy link
Contributor

rsparapa commented Oct 9, 2023

Which directory? I must have screwed my git!

@BrendanHalpin
Copy link
Contributor

My local setup is non-standard, but you'll see it in the "Code" tab on this page, alongside ess-stata-mode.el

@djh1202
Copy link
Author

djh1202 commented Oct 9, 2023

It's there: ess-stata-mode is separate from core ESS, but hasn't changed often. In fact, I feel like the only user, so Hi, djh1201!

Hi! Yes I use it quite a lot, so thanks for all your work over the years!

@rsparapa
Copy link
Contributor

rsparapa commented Oct 9, 2023

Oh, I forgot that it had moved. Doh

@rsparapa rsparapa closed this as completed Oct 9, 2023
@mmaechler mmaechler reopened this Oct 11, 2023
@roblem
Copy link

roblem commented Nov 29, 2023

When I replaced font-lock-reference-face with font-lock-constant-face, things started working again.

I can confirm that doing this fixes fontification bugs in orgmode src blocks when using emacs-jupyter and the nbstata kernel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants