Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support localization such as adding thousand separators to formatted numbers #1737

Open
krader1961 opened this issue Dec 18, 2023 · 0 comments

Comments

@krader1961
Copy link
Contributor

I just posted a comment to the chat channel that included a program illustrating the power of exponential growth. The output of the program would be easier to understand if the numbers included thousand separators so that values like 21474836.47 would appear as 21,474,836.47 (at least if you are in an English locale). It appears the recommended way to produce such output is to use the https://pkg.go.dev/golang.org/x/text/message package. So I'm opening this issue to see what people think about adding a dependency on that package. Note that I haven't yet measured how much adding that dependency increases the size of the Elvish binary. Obviously adding such a dependency is a non-starter if it greatly (whatever that means) increases the size of the Elvish binary. But I'm more curious if people think this would be useful if the increase in size was modest.

P.S., This is related to issue #1007.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant