Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default punctuation colour has changed #307

Open
linguini1 opened this issue Dec 11, 2023 · 4 comments
Open

Default punctuation colour has changed #307

linguini1 opened this issue Dec 11, 2023 · 4 comments

Comments

@linguini1
Copy link

Describe the bug
This plugin used to highlight punctuation in Gruvbox Orange, however it's been showing up as NeovimLightGray recently after I updated.

To Reproduce
Steps to reproduce the behavior:

  1. Use Neovim version NVIM v0.10.0-dev-1809+g529498685b
  2. Use the following setup:
return {
    "ellisonleao/gruvbox.nvim",
    priority = 1000,
    config = function()
        require("gruvbox").setup({
            contrast = "hard",
        })
        vim.cmd.colorscheme("gruvbox")
    end,
}

Expected behavior
Punctuation characters, such as {} and [] should show up as orange.

Screenshots
Here you can see that parenthesis and and commas show up in light gray. The curly braces are showing up as orange, but only because they're considered constructors. In C syntax, for example, they also show up as light gray.
image

Additional context
I have a hunch that this is due to Neovim recently changing the default color scheme. I'm thinking that maybe some of the highlight groups aren't getting overridden properly.

I can achieve the desired result with this config:

return {
    "ellisonleao/gruvbox.nvim",
    priority = 1000,
    config = function()
        require("gruvbox").setup({
            contrast = "hard",
            overrides = {
                ["@punctuation.bracket"] = { fg = "#fe8019" },
                ["@punctuation.delimiter"] = { fg = "#fe8019" },
                ["@punctuation.special"] = { fg = "#fe8019" },
            },
        })
        vim.cmd.colorscheme("gruvbox")
    end,
}
@mars90226
Copy link

mars90226 commented Dec 12, 2023

I also noticed this when I updated to the latest Neovim nightly. There's a related issue in Neovim #26378. Based on the Neovim developers' response, it seems that plugin maintainer should not depend on Vim's default highlight group.

mars90226 added a commit to mars90226/dotvim that referenced this issue Dec 12, 2023
@h3ndry
Copy link

h3ndry commented Feb 2, 2024

I am also having the same issue. Anyone know How to fix it and point me in the right direction. I can open a pull request

@tomben13
Copy link

tomben13 commented Feb 6, 2024

@punctuation.bracket, @punctuation.delimiter and @punctuation.special link to the Delimiter highlight group. But Delimiter link was removed in commit e57dd85.

I added this to my config:
["Delimiter"] = { link = "GruvboxOrange" },

Maybe this can be merged. See also: #80

@Owen000
Copy link

Owen000 commented Feb 8, 2024

I tried the above with no luck. Also tried this:
image
(still no luck) happened after I updated to latest nightly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants