DiffAdd is grey
#290
Comments
|
This is in the terminal with |
|
This seems to be related to
|
|
Here is how it looked before: In Outside of This is with |
|
Agree, Old style more confortable and clear to me, I use tag to revert it right now. |
|
Alright, so I fixed the See this SO answer. I still dislike the new styling however, so thankfully #291 gets us most of the way there (not quite: I want both the old colours and the low-key high-lighting from |
I dislike the new style of diff [1]. Thankfully somebody wrote a patch to configure it [2] (though not completely to my liking, so the local patch here is a bit different). I used it as a basis, but made it always revert, rather than configurable. [1]: ellisonleao/gruvbox.nvim#290 [2]: ellisonleao/gruvbox.nvim#291
I dislike the new style of diff [1]. Thankfully somebody wrote a patch to configure it [2] (though not completely to my liking, so the local patch here is a bit different). I used it as a basis, but made it always revert, rather than configurable. [1]: ellisonleao/gruvbox.nvim#290 [2]: ellisonleao/gruvbox.nvim#291
|
hey guys, thanks for opening the issue. I've made a comment in the PR so i really think this should be changed using overrides in your config. LMK if that work for you guys |
I dislike the new style of diff [1]. After somebody wrote a patch [2] I finally started experimenting with what looked best to me. This is using the old vibrant colours, which I like better. And avoids using `reverse = true` to not break high-lighting during visual selection. This is using an overlay as it is _much_ easier to refer to the internal colours in a `dark`/`light` agnostic way that way instead of the intended "use the palette way" (due to breaking changes in [3] which, incidentally, is the MR which changed diff high-lighting). [1]: ellisonleao/gruvbox.nvim#290 [2]: ellisonleao/gruvbox.nvim#291 [3]: ellisonleao/gruvbox.nvim#280
|
@ellisonleao I opened a discussion about an issue I have with |
Describe the bug
After updating the plug-in, the color of
DiffAddchanged from green to grey.To Reproduce
Steps to reproduce the behavior:
git commitwithcommit.verbose=trueconfigured.Expected behavior
I would expect it to be green, as it used to be.
Screenshots
Additional context
I'm not sure why it changed, as looking at the code/
:highlighteverything looks in order. I don't override any color in my config either.The text was updated successfully, but these errors were encountered: