Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate the project into better structure #36

Open
dayeya opened this issue Dec 11, 2023 · 2 comments
Open

Seperate the project into better structure #36

dayeya opened this issue Dec 11, 2023 · 2 comments

Comments

@dayeya
Copy link

dayeya commented Dec 11, 2023

If it isn't intentional, separating the project into separate folders may be the best for readability, easier navigation, and maintainability.

@elesiuta
Copy link
Owner

elesiuta commented Dec 12, 2023

I've been considering this for the past few releases. Originally a single file made it easier to distribute and run for less experienced users, but now it's grown to the point where it probably makes sense to split up, and I've now packaged it for most distros.

I also don't see picosnitch growing much larger, at least from my end since it has all the features I planned, with only minor changes from bug fixes or dependency updates remaining (I am open to pull requests with new features).

I have a local branch where I started working on this, and may just push as is later, but I don't have much experience with packaging, specifically the rpm and nix packages look like they'll break and will take some work since I'm not setup to build and test them right now.

A single file also made it simpler to re-execute as root or daemonize itself on systems without systemd, and since I don't spend much time on this anymore, I'm hesitant to make any breaking changes until someone who's made a few contributions wants to take over maintenance or volunteers to test and fix it on multiple distros.

For now there is a callgraph in the docs folder which can help with navigating the code.

@elesiuta
Copy link
Owner

I pushed the branch here https://github.com/elesiuta/picosnitch/tree/split-file where I just split the script into a module with no other changes or fixes for packaging, systemd, daemonizing, etc, and needs to be run with sudo python3 -m picosnitch

At this point it's basically just for interest and unlikely anything will come from it anytime soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants