Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mainview: simpler backlight detection #251

Merged
merged 10 commits into from May 14, 2024
Merged

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Feb 9, 2024

If there's no backlight then screen brightness will be -1

Maybe fixes #110

@danirabbit danirabbit requested a review from a team February 9, 2024 17:53
Copy link

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, I can test this when I get home tomorrow night

@zeebok
Copy link

zeebok commented May 14, 2024

Thought I had access to an iMac I could test this on but the person had got rid of it recently. From what I can tell it doesn't break anything though.

@danirabbit danirabbit merged commit 036eeac into main May 14, 2024
2 of 4 checks passed
@danirabbit danirabbit deleted the danirabbit/backlight-detect branch May 14, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brightness controls - missing
2 participants