Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom directory access gets overwritten when opening Applications plug #155

Closed
zelikos opened this issue May 2, 2021 · 4 comments · Fixed by #168
Closed

Custom directory access gets overwritten when opening Applications plug #155

zelikos opened this issue May 2, 2021 · 4 comments · Fixed by #168
Projects

Comments

@zelikos
Copy link

zelikos commented May 2, 2021

What Happened

If you give a Flatpak app access to a specific directory (such as the flatpak override command, or with Flatseal), opening the Applications plug overwrites this as the Permissions view doesn't currently support granular filesystem permissions.

An example of this in practice is for the Steam Flatpak; granting access to a specific directory, such as a separate/external drive containing your games library, is necessary if you don't want to, or can't, install all of your games in your home directory. The Steam Flatpak also doesn't run if access to the home directory is granted, so that can't be used as a workaround. Local overrides also seem to take priority over system-wide overrides, so having a system-wide override doesn't work as a workaround either, as the Applications plug leaves an empty override file if the app has default permissions.

Expected Behavior

Resolving #145 would be ideal in the long term.
In the short term, not overwriting access to specific directories (although I'm not sure if the short-term solution is feasible or not).

Steps to Reproduce

Using Steam as an example for simplicity, but any Flatpak app can be substituted:

  1. flatpak override --user --filesystem=/path/to/directory com.valvesoftware.Steam
  2. cat ~/.local/share/flatpak/overrides/com.valvesoftware.Steam to confirm directory access was granted
  3. Open System Settings -> Applications
  4. Repeat step 2, see custom directory is no longer there

Logs

Platform Information

elementary OS 6 Early Access

@queeup
Copy link
Contributor

queeup commented Aug 24, 2021

Confirm. Always resets my overrides.

@jalcine
Copy link

jalcine commented Aug 30, 2021

Okay, I thought I was freaking out here, thanks for confirming this! I wonder if it'd help to have another tab for apps to have 'mounted directories' or 'allowed paths' versus doing the "Home" / "System" all-or-nothing approaches.

@jhaygood86
Copy link
Contributor

This will be fixed by #168 -- underlying cause is that the plug didn't play nice with overrides set via other means

@jalcine
Copy link

jalcine commented Sep 16, 2021 via email

@danirabbit danirabbit added this to To do in OS 6.1 via automation Sep 23, 2021
@danirabbit danirabbit moved this from To do to In progress in OS 6.1 Sep 23, 2021
OS 6.1 automation moved this from In progress to Done Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants