You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detect if a remote is already added and do something?
Show a success view on success
Show an error view on error (both error parsing file and adding repo)
It seems like there's already quite a bit of duplicated UI code here, so I don't know if we want to do something more clever. But the success view and error view classes are pretty short and can probably be tweaked slightly to be the success view and error view for both Repos and Refs.
@davidmhewitt I'm a fan of this direction so far. :) I think the error view can probably be shared if that makes sense, but the success view is going to have a different title, body, and actions, so it might make sense to keep it separate. Something like:
Added “Flathub” to software sources
Non-curated apps and updates from “Flathub” will now appear in AppCenter.
I'm not sure if this is still being considered, but as it directly effects its app selection this should be an AppCenter dialog instead imo
Maybe there should be even more distinction between AppCenter and non-AppCenter apps?
@hanaral Sideload handles sideloading things from outside of AppCenter, including Flatpak refs, bundles, and (with this PR) repo files. This is still definitely wanted, but it'll need to be rebased on master as there have been a lot of changes there.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #72
Still do to:
It seems like there's already quite a bit of duplicated UI code here, so I don't know if we want to do something more clever. But the success view and error view classes are pretty short and can probably be tweaked slightly to be the success view and error view for both Repos and Refs.