Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Wallpaper Portal #753

Closed
danirabbit opened this issue Feb 27, 2024 · 2 comments · Fixed by #756
Closed

Use Wallpaper Portal #753

danirabbit opened this issue Feb 27, 2024 · 2 comments · Fixed by #756

Comments

@danirabbit
Copy link
Member

Problem

We're currently relying on Contractor for setting the wallpaper, but we should be using the Wallpaper Portal

Proposal

Use the Wallpaper Portal: https://valadoc.org/libportal/Xdp.Portal.set_wallpaper.html

Prior Art (Optional)

No response

@zeebok
Copy link
Contributor

zeebok commented Apr 28, 2024

It seems like this would involve updating Contractor to not report this action from the call to get_contracts_for_files() or specifically looking for the wallpaper option and replacing it with the libportal version. Given that we really want to see a rewrite maybe the latter option is better to triage this?

@danirabbit
Copy link
Member Author

We're no longer shipping the set wallpaper contract with desktop settings, so this just needs a branch like elementary/files#2432

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants