Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Toast.closed signal instead of Timeout for undo actions #978

Open
leolost2605 opened this issue Jan 23, 2024 · 1 comment
Open

Use Toast.closed signal instead of Timeout for undo actions #978

leolost2605 opened this issue Jan 23, 2024 · 1 comment

Comments

@leolost2605
Copy link
Member

Once elementary/granite#677 gets merged and eventually released it would be good to use the closed signal instead of a timeout to do the irreversible action. Otherwise we could end up with a situation where the user hovered over the toast too long and then clicks undo and nothing happens.

@robog-two
Copy link

Omg! This actually happened to me before in Geary and it was soul-crushing! This is definitely important especially because trashing an email is permanent, there's no trash folder or anything like that. (Though maybe there should be? And it follows the same settings from Housekeeping for trashed files?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants