Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translatability-related shortcomings #943

Closed
TomiOhl opened this issue Aug 3, 2023 · 5 comments
Closed

Translatability-related shortcomings #943

TomiOhl opened this issue Aug 3, 2023 · 5 comments

Comments

@TomiOhl
Copy link
Contributor

TomiOhl commented Aug 3, 2023

What Happened?

The new signature editor window has untranslatable text:
image
I cannot find these string on weblate. I'm maintaining the Hungarian translation and it's on 100% (except some lines in the Extras folder - old changelogs). E.g. if I search for "no signatures clearly visible on the above screenshot:
image

The context menu in the editor window also has untranslatable text (apparently I cannot take screenshots when context menus are open, but that's an unrelated issue). I mean the menu with options like cut/copy/paste.

Another issue is related to the new multi-touch gestures.
Swiping to the right on a conversation, you get "Archive".
These string are translated, however, the string for the word "Archive" is used in two files:

The problem: the first one is a verb, while the second one is a noun. These are the same in English, but they differ in some other languages (e.g. Hungarian).

Steps to Reproduce

Have Mail v7.2.0 and open the mentioned parts while the system language is anything but english.

Expected Behavior

All strings should be translatable.

There should be two separate strings for "Archive" - one for the noun, one for the verb.

OS Version

7.x (Horus)

Software Version

Latest release (I have run all updates)

Log Output

No response

Hardware Info

No response

@tintou
Copy link
Member

tintou commented Aug 3, 2023

Thanks for noticing and reporting the issue, I've pushed a fix at 013f410

@tintou tintou closed this as completed Aug 3, 2023
@TomiOhl
Copy link
Contributor Author

TomiOhl commented Aug 3, 2023

Thanks! However, I'm afraid the strings for the context menu still aren't included, and could you address the problem with the Archive string, too?

@tintou
Copy link
Member

tintou commented Aug 3, 2023

I've fixed the Archive string issue but the context menu is created by Webkit and should already be translated, unsure what is going wrong there

@tintou
Copy link
Member

tintou commented Aug 3, 2023

Opened #945 for this specific issue

@TomiOhl
Copy link
Contributor Author

TomiOhl commented Aug 3, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants