Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom back-button widget #484

Open
hanaral opened this issue Apr 14, 2021 · 3 comments
Open

Custom back-button widget #484

hanaral opened this issue Apr 14, 2021 · 3 comments
Labels
Needs Design Waiting for input from the UX team Priority: Wishlist Not a bug; but a new feature or enhancement

Comments

@hanaral
Copy link

hanaral commented Apr 14, 2021

Problem

The current solution isn't a long term one, and it likely going to look weird to new users who don't see icons inside buttons anywhere else.

Proposal

Now that libadwaita is a thing, I don't see why Granite shouldn't be able to actually function like a custom library with its own custom widgets. Since flatpak allows apps to bring the elementary stylesheet with them on other platforms the way they look shouldn't be too much of an issue anyway.

Prior Art

A quick mock-up:

granite-back-button

@cassidyjames
Copy link
Contributor

There was never anything stopping this technically, someone just needs to write the widget and ensure it picks up style and everything correctly. I do like the shaped button more than the icon button. 🙂

@hanaral
Copy link
Author

hanaral commented Apr 17, 2021

There was never anything stopping this technically, someone just needs to write the widget and ensure it picks up style and everything correctly. I do like the shaped button more than the icon button. slightly_smiling_face

Just to confirm, were talking about the same thing (custom widget drawing) here, right?
Maybe someone could kick this off by looking at how libhandy/adwaita does it, since they have plenty of custom stuff!

Edit: also what was with the bountysource plugin still adding stuff to my issue

@cassidyjames
Copy link
Contributor

Just to confirm, were talking about the same thing (custom widget drawing) here, right?
Maybe someone could kick this off by looking at how libhandy/adwaita does it, since they have plenty of custom stuff!

Yes. I think the issue is knowing how the border and shadows should work with an angled button, but I'm not personally familiar with how custom drawing works.

@lenemter lenemter added Priority: Wishlist Not a bug; but a new feature or enhancement Needs Design Waiting for input from the UX team labels Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Waiting for input from the UX team Priority: Wishlist Not a bug; but a new feature or enhancement
Projects
None yet
Development

No branches or pull requests

3 participants