Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR action to require/encourage some things on a PR #29

Open
cassidyjames opened this issue Jan 10, 2020 · 0 comments
Open

PR action to require/encourage some things on a PR #29

cassidyjames opened this issue Jan 10, 2020 · 0 comments
Labels
Needs Design Waiting for input from the UX team Priority: Wishlist Not a priority, but something that might be nice

Comments

@cassidyjames
Copy link
Contributor

cassidyjames commented Jan 10, 2020 •
edited

Could require:

  • Class: Changes title format. Wouldn't need to be too clever, just look for a word/phrase and colon at the beginning probably
  • A change to an AppData file. Would need an opt-out when there are no user-facing changes, maybe.
  • No changes to po files (since that's managed by Weblate)
  • Updated screenshot? Would need an opt-out when there are no user-facing changes.
  • …anything else?

The idea is to help us not miss common style/process things.
@cassidyjames cassidyjames added Priority: Wishlist Not a priority, but something that might be nice Needs Design Waiting for input from the UX team labels Jan 10, 2020
@cassidyjames cassidyjames changed the title PR action to require some things on a PR PR action to require/encourage some things on a PR Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs Design Waiting for input from the UX team Priority: Wishlist Not a priority, but something that might be nice
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cassidyjames