Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/hierarchy returns 403 when unknown room is accessible through federation #17143

Open
ajbura opened this issue May 2, 2024 · 0 comments · May be fixed by #17194
Open

/hierarchy returns 403 when unknown room is accessible through federation #17143

ajbura opened this issue May 2, 2024 · 0 comments · May be fixed by #17194
Labels
O-Occasional S-Minor T-Defect

Comments

@ajbura
Copy link

ajbura commented May 2, 2024

Description

/hierarchy returns 403 when room is not on server without trying to get it from federation.

Steps to reproduce

  • take roomId which is not on your server
  • ask for hierarchy
  • return 403 without checking over federation(even when it is available through federation)

Homeserver

matrix.org, envs.net

Synapse Version

{"server_version":"1.106.0rc1 (b=matrix-org-hotfixes,b9639065eb)"}

Installation Method

Docker (matrixdotorg/synapse)

Database

N/A

Workers

I don't know

Platform

N/A

Configuration

N/A

Relevant log output

N/A

Anything else that would be useful to know?

problem area:

synapse/synapse/handlers/room_summary.py

Line 187 in 7254015

if not await self._is_local_room_accessible(requested_room_id, requester):

it should also try to _summarize_remote_room_hierarchy before raising error
@ajbura ajbura changed the title /hierarchy returns 403 when room is not on server /hierarchy returns 403 when unknown room is accessible through federation May 5, 2024
@kfiven kfiven linked a pull request May 14, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O-Occasional S-Minor T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix hierarchy returning 403 when room is accessible through federation kfiven/synapse
2 participants
@erikjohnston @ajbura