Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should prompt users to clean up old devices more aggressively #2154

Closed
ara4n opened this issue Sep 10, 2016 · 9 comments
Closed

We should prompt users to clean up old devices more aggressively #2154

ara4n opened this issue Sep 10, 2016 · 9 comments

Comments

@ara4n
Copy link
Member

ara4n commented Sep 10, 2016

It's mildly alarming that #megolm has 20 users but 104 devices, as a result, each new megolm session requires sharing 104 new room_keys, which doesn't feel like it's going to scale. Perhaps when logging in and creating a new device, Vector should prompt the user to go clean out any old ones (as for the web case, it's likely the new tab is replacing an old lost tab

@richvdh
Copy link
Member

richvdh commented Oct 13, 2016

We'll need to look at #2464 and #2465 before we can fix this.

@richvdh
Copy link
Member

richvdh commented Feb 16, 2017

We should also delete devices on logout too (#3238)

@element-hq element-hq deleted a comment from lukebarnard1 Jun 19, 2017
@ara4n
Copy link
Member Author

ara4n commented Feb 12, 2019

This is getting more and more important, imo, especially to help protect users from the risk of 'ghost' devices which an attacker has added to try to intercept their comms.

@ara4n ara4n added P1 and removed P2 labels Feb 12, 2019
@aaronraimist
Copy link
Collaborator

Instead of on each login (because that would probably get annoying), you could have two sections in the device list, current devices and devices we think are old, maybe moved there after not being logged in to for 6 months.

I can't remember the issue number for in app notifications that aren't modal dialogs but then you could send some kind of in app notification saying we think you have old devices that can be cleaned up and with one click you can delete all the old devices (or select individual ones to delete).

Related: #8319

@jryans
Copy link
Collaborator

jryans commented Apr 30, 2020

The cross-signing work on develop (and to be released quite soon) addresses this via toasts that encourage reviewing both new and existing sessions, so I believe that's enough to consider this resolved.

@jryans jryans closed this as completed Apr 30, 2020
@aaronraimist
Copy link
Collaborator

@jryans I don't think so. When you setup cross signing for the first time you do get toasts for your existing sessions but it does not prompt you to clean them up. The only options are to verify them or to say it wasn't you in which case it says Your account is not secure and something has been compromised. There is no button to say, this is an old session, log me out of it.

Screen Shot 2020-04-30 at 10 26 28 AM

Also the text in this toast seems wrong. This is not a new login, this was an existing login from pre-cross signing.

@jryans
Copy link
Collaborator

jryans commented Apr 30, 2020

The toasts are rapidly changing. As of the last few days, many bugs and tweaks have landed with the toasts and continue to land as we speak, so it highly depends on exactly what version you are testing. If you are sure you're on latest develop and an existing session is shown as new, it may be a bug, so please file it separately.

For old sessions, we send you to user info to verify for now, as a bit of hack. Post-release we'll add proper session management with both verify and delete in a single place in settings (#11221).

@aaronraimist
Copy link
Collaborator

Yes that was on the latest /develop at the time of writing that comment. Looks like #13463 already exists for that.

@t3chguy
Copy link
Member

t3chguy commented Jun 3, 2020

I still think a periodic check of whether all your devices are still recently used would be desirable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants