Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updater lack proxy configuration #735

Open
k79e opened this issue May 28, 2021 · 2 comments · May be fixed by #58
Open

Updater lack proxy configuration #735

k79e opened this issue May 28, 2021 · 2 comments · May be fixed by #58
Labels
T-Defect

Comments

@k79e
Copy link

k79e commented May 28, 2021 •
edited

Description

The updater don't use proxy as main program.

Steps to reproduce

Set a http proxy e.g. --proxy-server=http://.....
And run program.
Then I find updater is using direct connection to check the update.

Describe how what happens differs from what you expected.

The updater should use proxy same as main program but it's not.

Logs being sent: yes/no

Version information

  • Platform: desktop

For the desktop app:

  • OS: Windows, macOS, Ubuntu, Arch Linux, etc?
  • win7 x64
  • Version: 1.x.y
  • 1.7.29
@k79e k79e added the T-Defect label May 28, 2021
@NHAS
Copy link

NHAS commented Oct 19, 2021

Hijacking this issue somewhat to give context to a pull request that would solve this.

Context from PR comments thread:

While element itself can use the electron --proxy-server option, this is not applied to the autoupdater which may lead to privacy issues as discussed previously in this issue.
Lacking this functionality also makes it harder to deploy these changes at scale.

For example, imagine a private matrix server that is behind a proxy, currently if we want to set up a number of devices to use it we would have to add a command line argument when Element is executed, which isnt standardised across multiple platforms (Im looking at you Mac).
Even with that argument added the auto updater will still dial out to the internet. Which may be not what users want.

@NHAS NHAS linked a pull request Oct 19, 2021 that will close this issue
Open
@NHAS
Copy link

NHAS commented Oct 19, 2021

@k79e Hey, the pull request that I've linked will add proxy support via config file to Element. Would it be possible for you to update the name of this issue to "Element lacks proxy configuration" or something similar, just so it can represent the pull request as well.

If not. All goods!

@k79e k79e changed the title Updater don't use proxy Updater lack proxy configuration Oct 20, 2021
@t3chguy t3chguy transferred this issue from element-hq/element-web Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added the ability to specify a proxy in the config.json file TheraNinjaCat/element-desktop
2 participants
@k79e @NHAS