Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for a full sync on startup #2372

Merged
merged 2 commits into from
May 22, 2024
Merged

Wait for a full sync on startup #2372

merged 2 commits into from
May 22, 2024

Conversation

AndrewFerr
Copy link
Member

This avoids missing any state not included in the latest cached sync.

Fixes #2359

This avoids missing any state not included in the latest cached sync.
src/matrix-utils.ts Outdated Show resolved Hide resolved
@robintown
Copy link
Member

Possibly fixes #2348

Copy link
Contributor

@toger5 toger5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments were apparently just a result of not knowing enough about cached syncs.
If you could add comments with details on this would be great.

src/matrix-utils.ts Show resolved Hide resolved
src/matrix-utils.ts Outdated Show resolved Hide resolved
@AndrewFerr
Copy link
Member Author

Re-requesting review to ask for feedback on:

@toger5
Copy link
Contributor

toger5 commented May 22, 2024

The comment makes it very clear to me.

Copy link
Contributor

@toger5 toger5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes

src/matrix-utils.ts Show resolved Hide resolved
src/matrix-utils.ts Show resolved Hide resolved
@AndrewFerr AndrewFerr merged commit c405b61 into livekit May 22, 2024
3 checks passed
@AndrewFerr AndrewFerr deleted the af/full-sync-on-startup branch May 22, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ECall can think you are joined to rooms that you've left
3 participants