Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--single-quotes doesn't work as expected #737

Open
caseywebdev opened this issue Nov 10, 2021 · 0 comments
Open

--single-quotes doesn't work as expected #737

caseywebdev opened this issue Nov 10, 2021 · 0 comments

Comments

@caseywebdev
Copy link

I tried to use --single-quotes and noticed it made no difference in the output. Dug through the code and it looks like this line doesn't actually do anything because .replace doesn't mutate the original string.

https://github.com/onderceylan/pwa-asset-generator/blob/a444f76b937d17e621bb5bb22b6352ea3d4fa9f2/src/helpers/meta.ts#L180

The line would need to be more like

htmlMeta[metaKey] = metaContent.replaceAll('"', "'");
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant