feat: add validation check for manual bp release notes #285
+135
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alicelovescake
changed the title
dsanders11
requested changes
Apr 22, 2024
dsanders11
requested changes
Apr 25, 2024
Comment on lines
+349
to
+355
| await updateBackportValidityCheck(context, checkRun, { | ||
| title: 'Invalid Backport', | ||
| summary: `The release notes of the backport PR do not match those of ${oldPRNumbers | ||
| .map((pr) => `#${pr}`) | ||
| .join(', ')}.`, | ||
| conclusion: CheckRunStatus.FAILURE, | ||
| }); |
There was a problem hiding this comment.
I think this is going to get clobbered by the update a bit further down in this file:
Lines 358 to 362 in 47f78d4
Might take some more refactoring to ensure the clobbering doesn't happen. However, I'm a bit worried about a regression since we don't have good test coverage here. Could you look at expanding test coverage in spec/index.spec.ts to cover updateBackportValidityCheck? A separate PR first expanding test coverage might be best since it will keep the changes in this one more concise.
There was a problem hiding this comment.
Thanks for the pointers!
- Created a PR to expand test coverage of index.spec.ts test: add test for updateBackportValidityCheck #289
- Updated the logic in this PR to move the release notes check after all the failure map check so it doesn't get clobbered
- After the test PR gets merged, I will update this PR with additional
updateBackportValidityCheckso we can be confident it works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
updateManualBackportReleaseNotes