Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDF Viewer moving to OOPIF upstream #41726

Closed
codebytere opened this issue Mar 28, 2024 · 0 comments · Fixed by #41728
Closed

PDF Viewer moving to OOPIF upstream #41726

codebytere opened this issue Mar 28, 2024 · 0 comments · Fixed by #41728
Assignees
@codebytere
Labels
component/pdf-viewer

Comments

@codebytere
Copy link
Member

See https://bugs.chromium.org/p/chromium/issues/detail?id=1445746:

Currently, the PDF Viewer is loaded and run in a GuestView. Not many applications use GuestView anymore, so migrate to loading and running the PDF Viewer in an out-of-process iframe instead.

It's currently gated behind a feature flag, but we should migrate our implementation correspondingly to account for the changes before the flag flips to enabled by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codebytere codebytere

Labels
component/pdf-viewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: move PDF viewer to OOPIF electron/electron
1 participant
@codebytere