Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Schemes not respected. #41548

Closed
3 tasks done
jmercouris opened this issue Mar 8, 2024 · 7 comments
Closed
3 tasks done

[Bug]: Schemes not respected. #41548

jmercouris opened this issue Mar 8, 2024 · 7 comments
Labels

Comments

@jmercouris
Copy link

Preflight Checklist

Electron Version

25.4.0

What operating system are you using?

Other Linux

Operating System Version

NixOS

What arch are you using?

x64

Last Known Working Electron version

No response

Expected Behavior

When a scheme is set to stream: true, it should allow streaming of a resource. When a scheme is set to stream: false, it should disable streaming of a resource.

Actual Behavior

The opposite behavior is observed.

Testcase Gist URL

https://gist.github.com/jmercouris/fca7cba9d8e6b30a2f861268a3180cff

Additional Information

No response

@fuwad121
Copy link

It seems the streaming behavior is the opposite of what's expected. I think flipping the stream property for each scheme could fix it : true for enable, false for disable in main.js
But, I could be mistaken.

@jmercouris
Copy link
Author

Another thing; when I set standard to true and false the dispatch of schemes will change. For example a: will dispatch on a standard scheme, but a:asdf will NOT dispatch on a standard scheme. This is what we may in fact be observing here.

@codebytere
Copy link
Member

codebytere commented Mar 11, 2024

@jmercouris see #41032 (which you were tagged in i think?)

tl;dr it's a misleading privilege that was implemented confusingly, and should probably be removed instead.

@codebytere codebytere closed this as not planned Won't fix, can't repro, duplicate, stale Mar 11, 2024
@jmercouris
Copy link
Author

I agree, it should probably be removed. However, there is an important point above within this issue that has not been addressed.

When I set standard to true and false the dispatch of schemes will change. For example a: will dispatch on a standard scheme, but a:asdf will NOT dispatch on a standard scheme. This is what we may in fact be observing here.

Please don't close issues unless the problems have been addressed. There is still a very deep bug that dispatch won't happen for 'standard' schemes when the URL appears to be malformed.

@jmercouris
Copy link
Author

Perhaps I should open up a new issue for this.

@codebytere
Copy link
Member

codebytere commented Mar 12, 2024

@jmercouris i hear you but the initial issue is a duplicate of an open one - i folded it into that issue which remains open. the second comment you made:

#41548 (comment)

is a different issue. I can re-open this issue if you change the PR body to reflect that as the primary issue you'd like investigated. You can of course also open a new issue.

@jmercouris
Copy link
Author

I've created a new issue #41601

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants