[Bug]: Application menu visible while embedded video is in fullscreen

[c3er]

Preflight Checklist

• I have read the Contributing Guidelines for this project.
• I agree to follow the Code of Conduct that this project adheres to.
• I have searched the issue tracker for a bug report that matches the one I want to file, without success.

Electron Version

24.3.1

What operating system are you using?

Windows

Operating System Version

Windows 11 22H2

What arch are you using?

x64

Last Known Working Electron version

No response

Expected Behavior

When a video is in fullscreen mode, only the video itself is visible, i.e. there is no menu on the screen.

Actual Behavior

When a video is in fullscreen mode, the application menu bar stays visible on top of the screen. See the screenshot below.

Testcase Gist URL

No response

Additional Information

I observed this problem on Windows. I didn't try Linux. On macOS, the behavior is as expected; but the application menu is outside the window there.

I made a minimal Electron application, to show this bug: https://github.com/c3er/electron-fullscreen-issue

The important part of this demo is the index.html file that contains a <video> tag referencing a local video file (downloaded from https://samplelib.com/).

[Suvrajit69]

Hello, I am newbie. Is this issue beginner friendly? what tech stack used in this project? what are the prerequisite for solving this issue. I am absolute beginner don't know how things works.

[c3er]

@Suvrajit69 I'm afraid, the Electron project is anything but beginner friendly.

First, you have to manage to build the project, which is already not trivial.

Then one has to work through millions of lines of C++ code to isolate and fix this problem. I don't dare this myself without help by somebody with good knowledge of this codebase. Also a setup of local development environment with debugging facility would be very helpful.

Also, C++ is quite a complex language with a steep learning curve -- not only for beginners but also people who know already other languages.

[Suvrajit69]

what this code is witten in c++? I saw this issue in electron web which is written in javascript I belive. I think I took the wrong way. haha. sorry.

[c3er]

@Suvrajit69 While Electron applications are written in JavaScript (and HTML, CSS of course), Electron itself is written in C++ (and additional languages). It is based on Chromium, the open source version of Google's Chrome browser.

[github-actions]

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

[c3er]

Didn't disappear magically in version 26.1.0. I updated my repro repo accordingly.

[electron-issue-triage]

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

[c3er]

Still no magic disappearance in version 27.1.3. Repro repo updated accordingly.

Please deactivate this so called triage bot. It hurts the contributor experience very badly and I think, I'm not the only one who is frustrated with this. A big count -- even a very big count -- of issues is only a problem if you're not able to prioritize them properly.

[mifi]

did you find any workaround? I found that if setting autoHideMenuBar: true in the BrowserWindow constructor, then the menu disappears completely in fullscreen (but also when not in fullscreen). see also discussion here: #543

[mifi]

I found in the source code that windows is handled differently from the others.

Windows:

electron/shell/browser/native_window_views.cc

Line 720 in cee5178

#if BUILDFLAG(IS_WIN)

Others:

electron/shell/browser/native_window_views.cc

Line 756 in cee5178

#else

specifically, the auto-hide menu bar code only gets called for non-windows:

electron/shell/browser/native_window_views.cc

Line 763 in cee5178

// Auto-hide menubar when in fullscreen.

not sure what's the reasoning for that, but someone on windows could try to enable that for Windows too and see if it helps

[electron-issue-triage]

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

[mifi]

still a bug i bielieve

[c3er]

I can confirm this with version 30.0.3. The menu bar in the newest Electron got a little higher, both in the Electron window (I like this actually) and in fullscreen mode, described above (which makes the bug a little worse).

So, it seems like a bug is not like a bread, that gets stale with time.