Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add video and audio codecs #3259

Closed
rhnorskov opened this issue Oct 29, 2015 · 3 comments
Closed

Add video and audio codecs #3259

rhnorskov opened this issue Oct 29, 2015 · 3 comments

Comments

@rhnorskov
Copy link

I am looking for a way to playback videos with ac3 audio, and xvid videos.

@zcbenz
Copy link
Member

zcbenz commented Oct 29, 2015

You have to do a custom build libchromiumcontent with custom ffmpeg_branding, currently we just use the chrome browser's setting since it is well tested. You can find more at #1595.

@zcbenz zcbenz closed this as completed Oct 29, 2015
@rhnorskov
Copy link
Author

Ok, it looks like none of the existing ffmpeg_branding brands support ac3, and looking at vendor\chromium\src\third_party\ffmpeg\build_ffmpeg.py line 493 it looks like i need to add some flags to the ffmpeg build

# Google Chrome & ChromeOS specific configuration.
configure_flags['Chrome'].extend([
    '--enable-decoder=aac,h264,mp3',
    '--enable-demuxer=aac,mp3,mov',
    '--enable-parser=aac,h264,mpegaudio',
])

How is this done? Do I make a patch in patches\third_party\ffmpeg? Or am I on the completely wrong track?

@amilajack
Copy link

What is the modern way of doing this? This issue seems pretty old so I'm sure things have changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants