Enable PDF Viewer

[alexeykuzmin]

It was disabled during the Chromium 63 upgrade in #11459.
Please turn enable_pdf_viewer flag in the features.gypi on, fix compilation and tests.

[ckerr]

@sethlu @gnahzak have either of you had time to work on this?

This is still a 3.0.0 blocker

[sethlu]

@ckerr We didn't get to make much progress since #13760 opened.

[nornagon]

relevant: https://bugs.chromium.org/p/chromium/issues/detail?id=702993

[nornagon]

This should be ready to test out in the next 10.x nightly. I'm hoping to backport to 9.x as well, though it may not end up sticking if it causes issues.

[davwheat]

OH MY GOD THANK YOU SO MUCH YOU BEAUTIFUL BEAUTIFUL PERSON!!

[godza]

I can confirm that in latest nightly build (10.0.0-nightly.20200216) PDF viewer works again. Thanks for hard work to everyone involved.

[geesen]

Thank you for this long-awaited feature!
Does this somehow include the ability to print?

[godza]

Thank you for this long-awaited feature!
Does this somehow include the ability to print?

In my app, PDF print still does not work. I'm getting these errors "ipc_message_attachment_set.cc MessageAttachmentSet destroyed with unconsumed attachments"

[teckwrek]

Hi @nornagon .... I confirmed that PDF viewer works and my part of the bounty is yours!

Could I request that the download and print functionality be fixed as well?

[HitomiTenshi]

@godza @teckwrek It's a known issue at the moment. @nornagon wanted to release a working PDF viewer first and tie up the rest afterwards. Thanks again @nornagon !

See follow-up issues:
#22179
#22178
#22180

[Order256]

@nornagon thanks for fixing the PDF. I saw that it's supposed to be in Electron 9.0.0-beta.2 unfortunately i only get a grey background and 3 icons when i try to load a PDF file.

[nornagon]

@Order256 Ah, yeah, I'm seeing the same thing. Opened #22286 to track the issue.

[pbmzero]

I'm not sure what to do with the bounty on my end, when i tried it with electron-nightly@10.0.0-nightly.20200218 and I assume I hit bug #22286

[nornagon]

@pbmzero do you have a link to the pdf you're having trouble with? https://gist.github.com/248085f4c2376e9211479f2d09634050 this works for me in 10.0.0-nightly.20200218.

[pbmzero]

@nornagon Ok it worked if i loaded the PDF directly like you showed in your code snippet.

I expected that it would work inside iframe per this example: https://www.w3docs.com/tools/code-editor/1087

[nornagon]

This example works for me in an iframe: https://gist.github.com/c097b618d2c1cfccf99c6a80fb15c550

[pbmzero]

@nornagon Indeed it works. I'll go ahead and release bounty. Hoping this sticks!

[djbusby]

For me electron-nightly@10.0.0-nightly.20200221 is working perfectly for six PDF view cases I've got -- this is excellent work, many thanks! Just hoping to get print feature.

[godza]

I've tried latest 9.0.0 build (beta 3) and pdf preview is working for me now. Thanks again!

[waltder]

Any idea when version 9.0.0 beta 3 or greater (even version 10) will become an official release?

[jkleinsc]

@waltder Electron 9 stable date has been moved to Chromium's M83 stable date, May 19th. There is a PR in process here electron/electronjs.org-old#3770 to update the website.

[waltder]

@jkleinsc Thanks for the info.

[waltder]

Will the print and download features be fixed any time soon?

[heimlich]

Great news that the pdf viewer is working again. Thank you very much!
There already exist two open tickets for printing #22179 and downloading #22178

@nornagon Are you going to work on these tickets too? Or can you give an estimate of the effort?

[ajgadev]

Hello! i'm using Electron 9.0.5 stable but when i try opening a pdf it's a grey screen. Am i missing something?

[tidg]

Hi,
On my side this bad behaviour was due to this simple piece of code app.commandLine.appendSwitch('disable-site-isolation-trials');
I don't understand the relationship between the PDF feature and this part of the code but when I remove it, it works as expected.

[ncortines]

This seems to be broken on 18.0.3. Seems to work fine on 17.4.0 though