-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notification API do not work with Windows 10 16299.19 (fall creators update) #10864
Comments
I am also able to reproduce this with the following setup:
Looking at the build changes they have poked around in notifications: https://changewindows.org/build/16299/pc Other applications has successfully shown notifications in Windows 10 16299.19, both Windows Defender and a third party app. |
For the record I've been on the fast insiders track all year and have never had this problem, I'm currently on 17017 and double checked, notifications still work perfectly fine. I'd suggest y'all got a broke build in 16299, when you update out of that version I wouldn't be surprised if this starts working for you again. |
First of all, 👋 Gregor! Lange nicht mehr gesehen! Secondly, the notification API in Windows 10 remained fundamentally the same, so this isn't gonna be easy. Action Center is pretty unreliable though - and apparently, as I learned from the notification team a few days ago, things can fall apart all the time. I can also confirm the bug on 16299.19, but I'd like to make double-sure that this isn't on Windows. I'll take a look at this. As a short-term solution, |
I can reproduce this, neither of my apps show notifications in Windows 10 17025. |
Same here.
The second build is the official IE Testing VM already running the Fall Creators Update. @felixrieseberg Is there something we can do to support you in any way? |
Same, my app broke as well with Fall Creators update :( |
Macrium Reflect team says the update has restricted the number of apps that can register for notifications (link below). Not sure if this is related but I can confirm that in addition to my Electron app being able to send notification on a pre-Fall Creators Update computer and not a post fall update computer, my app also no longer shows in the "Get notifications from these senders list" after updating whereas it did before. https://knowledgebase.macrium.com/display/KNOW7/Windows+10+Notifications+-+1709+Fall+Creators+Update |
Same problem here. Upgraded to the Fall Creators Update and no more notifications. |
I have the same issue. |
Can anyone confirm that switching to |
@levinunnink at least not for me. I tried it directly with the nodeRT as well but without success ( |
So right now there is no known way to get notifications working on Electron + Windows 10 16XXX? Seems like a major problem. It's certainly breaking my app big time. Is anyone working on this? |
As a not very satisfying workaround, I'm using a modified version of |
I think I found a fix! Calling https://electronjs.org/docs/api/app#appsetappusermodelidid-windows Can anyone else confirm that this fixes the issue? If this works for everyone, the documentation seriously needs to be updated. |
@levinunnink |
Same issue here. |
Quick question: Which appUserModelId are you using to fix this? Electron already calls |
@felixrieseberg We ship our app using |
That did it! Using |
Somewhat related: #11331 |
Thanks a lot! It works. |
I cannot solve the problem 👎 Details:
Main code:
Software: |
@Praveer1981, you could take a look at this: Please take some time to read back because some might work for you and sometimes not depending on the scenario you are in but for the most part, having the proper shortcut and GUID/appID when packaged or setting |
Yup. Used that method since 2018. No trouble to this day. |
@roelpaulo Thanks for the guidance. I will check this hope it will solve my problem |
@roelpaulo I am still trying to fix the notification issue |
Did you try the method in my old comment that @roelpaulo tagged? I just tried it and works like perfectly. I discovered that method pretty much by chance and fortunately it has become a permanent solution. Setting the |
@m4heshd Thanks for your comment. Yes, I tried what @roelpaulo mentioned. Could you please have a look on my code (which is not working ) |
Your code won't work because It's not updated with the solution I explained on that comment. Add these lines on top of your code (right after
Before you try this, you need to add a shortcut of that |
@m4heshd I do not understand why do we nee to give |
@felixrieseberg It doesnot look like |
@Praveer1981, I myself do not understand at first but it is the requirement that MS put on every app to have a proper shortcut and GUID in order for the notifications to work. As I understand as a whole, it is a requirement, not a code work-around. |
@Kikketer Did you manage to get the solution/workaround ? |
Thank you for taking the time to report this issue and helping to make Electron better. The version of Electron you reported this on has been superseded by newer releases. If you're still experiencing this issue in Electron 6.x.y or later, please add a comment specifying the version you're testing with and any other new information that a maintainer trying to reproduce the issue should know. I'm setting the Thanks in advance! Your help is appreciated. |
@electron-triage I have pushed the source code in my gitgub: However, It does not work in the PC which has below configuration I have tried with below version of NODE |
I managed to solve the problem in my real application: |
I encountered the same problem I did not receive any notification in windows until I separated the notification call with the show() function like this
|
This worked for me. I also had setAppUserModelId set as well. |
Hey @Tepexic, can I know how do set the package.json? And what value did you pass into setAppUserModelId? Is it appId or process.execPath? Thanks |
Hey @m4heshd, I tried to use the method you mentioned, https://www.electronjs.org/docs/tutorial/notifications#windows. But I still can not get the notification. I used Windows 10.
Can I know how to fix that? |
I did it manually, like this: I don't have anything special on the package.json, other than this: |
Gotcha, since I did not set the appId in the package.json. I set the appId in electron-builder.yml according to this tutorialhere. I tried this code change, but it did not work for me. Can I know if I miss something? Thanks! OS: Window 10
|
me too |
This issue seems to have become a dumping ground for a variety of notification-related issues on Windows, but I don't think the original issue is still relevant. I'm closing + locking this issue, if you're encountering problems using notifications on Windows, please open a new issue and fill out the template. |
Expected behavior
Create a desktop notifications.
Actual behavior
No notification.
How to reproduce
Try with yours https://github.com/electron/electron-api-demos
The text was updated successfully, but these errors were encountered: