Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e d rbe login randomly fails on Windows #587

Open
piotrpdev opened this issue May 2, 2024 · 2 comments
Open

e d rbe login randomly fails on Windows #587

piotrpdev opened this issue May 2, 2024 · 2 comments

Comments

@piotrpdev
Copy link

Operating System

Windows version: Microsoft Windows 11 Pro 10.0.22631 Build 22631
Node.js version: v20.10.0
NPM version: 10.2.3
Build tools version: @electron/build-tools@1.2.0
Electron RBE helper version: v0.2.2/electron-rbe-credential-helper-windows-amd64.tar.gz

PS C:\Users\peter> systeminfo | findstr /B /C:"OS Name" /B /C:"OS Version"
OS Name:                   Microsoft Windows 11 Pro
OS Version:                10.0.22631 N/A Build 22631
PS C:\Users\peter> npm list -g --depth=0
C:\Program Files\nodejs -> .\
+-- @electron/build-tools@1.2.0
+-- corepack@0.22.0
`-- npm@10.2.3

PS C:\Users\peter> yarn --version
1.22.21

Expected Behavior

e d rbe login works every time.

Actual Behavior

e d rbe login randomly fails for no apparent reason.

To Reproduce

Try running e d rbe login a couple of times on Windows? I'm honestly not sure, when the command fails it does not give a very helpful error.

Screenshots

Fails in Windows Terminal PowerShell:

2024-05-02.19-47-35.mp4

Fails in Command Prompt:

2024-05-02.19-49-41.mp4

Fails during e init:

Screenshot 2024-05-02 191958

Additional Information

Also tried updating Goma, it did not help.

Screenshot 2024-05-02 192846

PS C:\Users\peter> e update-goma
Writing new goma.gn file C:\Users\peter\.electron_build_tools\third_party\goma.gn
Downloading "https://dev-cdn.electronjs.org/goma-clients/8644a9443d03675cc113a26b42a20e97e41e4f4d152ff84140a9a93ea6830a08/goma-win.zip" into C:\Users\peter\.electron_build_tools\third_party\goma-win.zip
goma checksum: 8644a9443d03675cc113a26b42a20e97e41e4f4d15284140a9a93ea6830a08
@dsanders11
Copy link
Member

This could be caused by the local clock time on the machine being off by a small amount. Could you use https://time.is/ to check?

@piotrpdev
Copy link
Author

This could be caused by the local clock time on the machine being off by a small amount. Could you use time.is to check?

Seems so:

image

My machine automatically synced 4 days ago though, isn't it a bit dumb that's not good enough? Giving the user this information would also be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants