feat: allow build-tools to be used with non-standard (e.g. non-github) repositories #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlackHole1
requested review from
ckerr,
codebytere and
MarshallOfSound
as code owners
ckerr
reviewed
Feb 7, 2022
| @@ -77,7 +79,7 @@ function runGClientConfig(config) { | |||
| '--name', | |||
| 'src/electron', | |||
| '--unmanaged', | |||
| 'https://github.com/electron/electron', | |||
| config.remotes.electron.origin, | |||
There was a problem hiding this comment.
Does this change still work on the default repo when useHttps is not set, i.e. when origin is git@github.com:electron/electron.git?
It looks like the https:// being replaced here was here since the initial commit, so I can't tell from the comment history whether its use was intentional or if it snuck in by accident.
|
Closing as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed: #302